ggriffiniii

ggriffiniii commented on issue wathiede/i3xs#1

2019-10-01 23:20:20 -07:00

Have DateTimeWidget include the time zone in its type.

Here are the benefits that I see, but I think there's plenty of room for reasonable people to disagree on these things.

ggriffiniii commented on issue wathiede/i3xs#1

2019-10-01 22:54:56 -07:00

Have DateTimeWidget include the time zone in its type.

Well I think it may not actually be necessary here (and should probably be removed), but it is necessary on the Widget impl. Short answer for why it's necessary there is because the compiler said so. Longer answer is because the Widget impl formats the time, which requires displaying the timezone which can only be done if the timezone's offset has a Display impl.

ggriffiniii pushed to master at ggriffiniii/i3xs

2019-10-01 11:38:01 -07:00

de6bef6e36 More datetime changes

ggriffiniii pushed to master at ggriffiniii/i3xs

2019-10-01 08:49:34 -07:00

faae3bebca Have DateTimeWidget include the time zone in its type.

5f2795f5d2 Have DateTimeWidget include the time zone in its type.

Compare 2 commits »

ggriffiniii created pull request wathiede/i3xs#1

2019-09-30 15:54:55 -07:00

Have DateTimeWidget include the time zone in its type.

ggriffiniii pushed to master at ggriffiniii/i3xs

2019-09-30 15:54:26 -07:00

5f2795f5d2 Have DateTimeWidget include the time zone in its type.

ggriffiniii created repository ggriffiniii/i3xs

2019-09-30 15:53:55 -07:00